[fix][client] handle subscriptionRolePrefix properly #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415
Motivation
At my current employer, we have a centrally-managed Pulsar cluster that requires use of a pre-assigned
subscriptionRolePrefix
for your client when creating a reader.As per docs, you should be able to do this with:
However, this bug prevents that from working correctly.
Modifications
Small change in
ReaderConfig.cc
to call the correctPULSAR_PUBLIC
function.Verifying this change
This change is a trivial rework / code cleanup without any test coverage. That said: I did test that, by using my patched client, I can create a reader in our internal setup described above. (Without the patch, it fails.)
(Due to NDA, I can't describe that setup in more detail, sadly.)
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)
Docs are not needed: this fixes a feature that is already documented, but which did not previously work as intended.